A Better Way to Do a For Loop with Two Lists?

Pertussic

Noob here.  I have a nested for loop that uses two lists that selects specific diagnostic codes from multiple diagnosis columns.  It works, but I was wondering if there's a better way to code it.

 

ColumnList = {"DIAGNOSIS_1", "DIAGNOSIS_2", "DIAGNOSIS_3"};
ValueList = {"E871","O480","J449"};*/
For( i = 1, i <= N Items( ColumnList ), i++, 
	ColumnItem = ColumnList[i];
	Eval(
		Eval Expr(
			As Constant( col = As Name( Expr( ColumnItem ) ) );
			For( j = 1, j <= N Items( ValueList ), j++, 
				ValueItem = ValueList[j];
				all_ip << select where( As Column( col ) == ValueItem, Current Selection( "extend" ) );
			);
		)
	);
);

Craige_Hales

Maybe this is what you are trying to do.

 

dt = Open( "$sample_data/big class.jmp" );
ColumnList = {"height", "weight", "age"};
ValueList = {13, 128, 60};
For Each( {col}, ColumnList,
	For Each( {ValueItem}, ValueList,
		dt << select where( As Column( dt, col ) == ValueItem, Current Selection( "extend" ) )
	)
);

or even this

 

dt = Open( "$sample_data/big class.jmp" );
ColumnList = {:height, :weight, :age};
ValueList = {13, 128, 60};
For Each( {col}, ColumnList,
	For Each( {ValueItem}, ValueList, dt << select where( col == ValueItem, Current Selection( "extend" ) ) )
);

(It might make sense with your data, but with big class it doesn't make a lot of sense to select rows where height or weight or age are 13, or where height or weight or age are 128, or where height or weight or age are 60. Just using it to try to match what I think you mean.)